linux-kernel - Re: [PATCH v3] arm64: defconfig: Enable Ftrace and STM configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJppugcJC8nk8C0u9D=WcO8_MVE5aHC+1nNfxWNfCAvNBYQ@mail.gmail.com>
Date: Tue, 24 Sep 2024 11:29:58 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Mao Jinlong <quic_jinlmao@...cinc.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, 
	Bjorn Andersson <quic_bjorande@...cinc.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Arnd Bergmann <arnd@...db.de>, Nícolas F . R . A . Prado <nfraprado@...labora.com>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] arm64: defconfig: Enable Ftrace and STM configs

On Tue, 24 Sept 2024 at 11:21, Mao Jinlong <quic_jinlmao@...cinc.com> wrote:
>
> To make software trace sources go through STM(System Trace Module),
> need to enable STP (System Trace Protocol) protocols and stm sources.
> Refer to Documentation/trace/stm.rst. Then software trace logs can be
> captured by STM over TMC sink path. We can enable software trace(Ftrace,
> console) logs along with HW trace of coresight component. The timestamp
> of software trace logs and hw traces will be in sync which helps to
> debug.

It doesn't looks as if you've read the file that I've pointed out previously.

You must describe why your changes are to be enabled for a random user
(not just for some kernel developer or hardware enabled). Do you need
STM and FTRACE in your distro kernel running on your laptop which you
use for the daily work?

For reference, CONFIG_FTRACE is enabled only in 2 defconfig files (and
explicitly disabled in 70).

>
> Changes in v3:
> - update commit message.
>
> Changes in v2:
> - select ftrace config explicitly.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
> ---
>  arch/arm64/configs/defconfig | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 4a3999eefa67..c0a56e58e554 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1554,6 +1554,12 @@ CONFIG_NVMEM_SNVS_LPGPR=y
>  CONFIG_NVMEM_SPMI_SDAM=m
>  CONFIG_NVMEM_SUNXI_SID=y
>  CONFIG_NVMEM_UNIPHIER_EFUSE=y
> +CONFIG_STM_PROTO_BASIC=m
> +CONFIG_STM_PROTO_SYS_T=m
> +CONFIG_STM_DUMMY=m
> +CONFIG_STM_SOURCE_CONSOLE=m
> +CONFIG_STM_SOURCE_HEARTBEAT=m
> +CONFIG_STM_SOURCE_FTRACE=m
>  CONFIG_FPGA=y
>  CONFIG_FPGA_MGR_ALTERA_CVP=m
>  CONFIG_FPGA_MGR_STRATIX10_SOC=m
> @@ -1663,7 +1669,7 @@ CONFIG_DEBUG_INFO_REDUCED=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_FS=y
>  # CONFIG_SCHED_DEBUG is not set
> -# CONFIG_FTRACE is not set
> +CONFIG_FTRACE=y
>  CONFIG_CORESIGHT=m
>  CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
>  CONFIG_CORESIGHT_CATU=m
> --
> 2.46.0
>


-- 
With best wishes
Dmitry