linux-kernel - Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1931378.eGJsNajkDb@phil>
Date: Tue, 24 Sep 2024 11:31:45 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Marc Kleine-Budde <mkl@...gutronix.de>, kernel@...gutronix.de,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Geert Uytterhoeven <geert+renesas@...der.be>
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP

Am Dienstag, 24. September 2024, 11:15:31 CEST schrieb Geert Uytterhoeven:
> The Rockchip CAN-FD controller is only present on Rockchip SoCs.  Hence
> add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this
> driver when configuring a kernel without Rockchip platform support.
> 
> Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

makes a lot of sense, and with the compile-test in, it'll still get
test-build

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/net/can/rockchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig
> index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644
> --- a/drivers/net/can/rockchip/Kconfig
> +++ b/drivers/net/can/rockchip/Kconfig
> @@ -3,6 +3,7 @@
>  config CAN_ROCKCHIP_CANFD
>  	tristate "Rockchip CAN-FD controller"
>  	depends on OF || COMPILE_TEST
> +	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	select CAN_RX_OFFLOAD
>  	help
>  	  Say Y here if you want to use CAN-FD controller found on
>