linux-kernel - Re: [PATCH 1/7] linux-kbuild: fix: config option can be bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATkjh8LR58+SZPw44ezbRj6-aisQ9nsUoTY_6yVf+t3Mg@mail.gmail.com>
Date: Tue, 24 Sep 2024 11:55:08 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	shuah@...nel.org, javier.carrasco.cruz@...il.com
Subject: Re: [PATCH 1/7] linux-kbuild: fix: config option can be bool

"linux-kbuild: fix:" is not an appropriate subject prefix.

Just try "git log scripts/kconfig/streamline_config.pl".


You will see  "streamline_config.pl:" is consistently used
for the commit subject.


For example,

"streamline_config.pl: check prompt for bool options"




On Sat, Sep 14, 2024 at 2:12 AM David Hunter
<david.hunter.linux@...il.com> wrote:
>
> Select configs that do not have a prompt. Config options can be bool or
> tristate. Ensure that bool options are also selected.


I do not see an immediate benefit from this patch.



Boolean CONFIG options are skipped due to the following code:

if (defined($orig_configs{$config}) && $orig_configs{$config} ne "m") {
    next forloop;
}


So, I do not understand why this patch is necessary
until I see 7/7.




>
> Signed-off-by: David Hunter <david.hunter.linux@...il.com>
> ---
>  scripts/kconfig/streamline_config.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index d51cd7ac15d2..a828d7ab7e26 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -238,7 +238,7 @@ sub read_kconfig {
>             }
>
>         # configs without prompts must be selected
> -       } elsif ($state ne "NONE" && /^\s*(tristate\s+\S|prompt\b)/) {
> +       } elsif ($state ne "NONE" && /^\s*((bool|tristate)\s+\S|prompt\b)/) {
>             # note if the config has a prompt
>             $prompts{$config} = 1;
>




--
Best Regards

Masahiro Yamada