linux-kernel - Re: [PATCH 2/7] linux-kbuild: fix: missing variable operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAR7+Z4ZMP7seXRAzednWTdvsbNOef4Oxk75yWPNNwe3Zw@mail.gmail.com>
Date: Tue, 24 Sep 2024 12:04:14 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	shuah@...nel.org, javier.carrasco.cruz@...il.com
Subject: Re: [PATCH 2/7] linux-kbuild: fix: missing variable operator

Good catch, but please fix the subject prefix.

For example,

streamline_config.pl: fix missing variable operator in debug print





On Sat, Sep 14, 2024 at 2:12 AM David Hunter
<david.hunter.linux@...il.com> wrote:
>
> Put in the dollar sign for the variable '$config'. That way, the debug
> message has more meaning.
>
> Signed-off-by: David Hunter <david.hunter.linux@...il.com>
> ---
>  scripts/kconfig/streamline_config.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index a828d7ab7e26..ddc630f2264a 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -503,7 +503,7 @@ sub parse_config_selects
>
>             # Check if something other than a module selects this config
>             if (defined($orig_configs{$conf}) && $orig_configs{$conf} ne "m") {
> -               dprint "$conf (non module) selects config, we are good\n";
> +               dprint "$conf (non module) selects $config, we are good\n";
>                 # we are good with this
>                 return;
>             }
> --
> 2.43.0
>


-- 
Best Regards
Masahiro Yamada