linux-kernel - Re: [PATCH 7/9] spi: spi_amd: Enhance SPI-MEM support functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52f6b06a-ba0d-c736-81d2-cdf5a3802b66@amd.com>
Date: Tue, 24 Sep 2024 20:55:04 +0530
From: "Rangoju, Raju" <raju.rangoju@....com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
 sanju.mehta@....com, krishnamoorthi.m@....com, akshata.mukundshetty@....com
Subject: Re: [PATCH 7/9] spi: spi_amd: Enhance SPI-MEM support functions



On 9/19/2024 2:21 PM, Mark Brown wrote:
> On Wed, Sep 18, 2024 at 04:20:35PM +0530, Raju Rangoju wrote:
> 
>> AMD SPI0 controller supports quad mode only for read operations and has
>> limited support for quad mode writes. And, the AMD HID2 SPI controller
>> supports DMA read, allowing for up to 4 KB of data to be read in single
>> transaction. Update the SPI-MEM support functions to reflect these hardware
>> capabilities.
> 
>>   	/* bus width is number of IO lines used to transmit */
>> -	if (op->cmd.buswidth > 1 || op->addr.buswidth > 4 ||
>> -	    op->data.buswidth > 4 || op->data.nbytes > AMD_SPI_MAX_DATA)
> 
> So this code you added earlier in the series is clearly buggy...  this
> whole change should've been part of that patch, and the addidion of the
> patch adding the new HID.

Sure, I will take care of this in V2.