linux-kernel - Re: [PATCH v1 5/9] PCI: imx6: Make core reset assertion deassertion symmetric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvLnnMUcRhzGr1I6@lizhi-Precision-Tower-5810>
Date: Tue, 24 Sep 2024 12:23:56 -0400
From: Frank Li <Frank.li@....com>
To: Richard Zhu <hongxing.zhu@....com>
Cc: l.stach@...gutronix.de, kwilczynski@...nel.org, bhelgaas@...gle.com,
	lpieralisi@...nel.org, robh+dt@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	festevam@...il.com, s.hauer@...gutronix.de,
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	kernel@...gutronix.de, imx@...ts.linux.dev
Subject: Re: [PATCH v1 5/9] PCI: imx6: Make core reset assertion deassertion
 symmetric

On Tue, Sep 24, 2024 at 11:27:40AM +0800, Richard Zhu wrote:
> Add apps_reset deassertion in the imx_pcie_deassert_core_reset().
> Let it be symmetric with imx_pcie_assert_core_reset().
>
> Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> ---
Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/pci/controller/dwc/pci-imx6.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index d49154dbb1bd..f306f2e9dcce 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -770,6 +770,7 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie)
>  static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
>  {
>  	reset_control_deassert(imx_pcie->pciephy_reset);
> +	reset_control_deassert(imx_pcie->apps_reset);
>
>  	if (imx_pcie->drvdata->core_reset)
>  		imx_pcie->drvdata->core_reset(imx_pcie, false);
> --
> 2.37.1
>