linux-kernel - RE: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DU2PR04MB8677A659D73AB056EFE0B4158C692@DU2PR04MB8677.eurprd04.prod.outlook.com>
Date: Wed, 25 Sep 2024 02:31:41 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Conor Dooley <conor@...nel.org>, Frank Li <frank.li@....com>
CC: "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"kwilczynski@...nel.org" <kwilczynski@...nel.org>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"festevam@...il.com" <festevam@...il.com>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95
 PCIe

> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: 2024年9月25日 0:04
> To: Frank Li <frank.li@....com>
> Cc: Hongxing Zhu <hongxing.zhu@....com>; l.stach@...gutronix.de;
> kwilczynski@...nel.org; bhelgaas@...gle.com; lpieralisi@...nel.org;
> robh+dt@...nel.org; conor+dt@...nel.org; shawnguo@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; festevam@...il.com;
> s.hauer@...gutronix.de; linux-pci@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; kernel@...gutronix.de; imx@...ts.linux.dev
> Subject: Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95
> PCIe
> 
> On Tue, Sep 24, 2024 at 11:23:06AM -0400, Frank Li wrote:
> > On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote:
> > > On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote:
> > > > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5
> > > > and keep the same restriction with other compatible string.
> > > >
> > > > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > >
> > > It'd be really good to mention why this clock is appearing now, when
> > > it did not before. You're just explaining what you've done, which
> > > can be seen in the diff, but not why you did it.
> >
> > Previous reference clock of i.MX95 is on when system boot to kernel.
> > But boot firmware change the behavor, so it is off when boot. So it
> > need be turn on when it use. Also it need be turn off/on when suspend and
> resume.
> > Previous miss this feature.
> 
> Please put this in the commit message Richard.
Hi Conor:
Thanks for your comments.
Would add these information in the commit message later.

Best Regards
Richard Zhu
> 
> Thanks,
> Conor.