linux-kernel - Re: [PATCH 13/23] kbuild: replace two $(abs_objtree) with $(CURDIR) in top Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvQd1I-nyxZGAsIb@l-nschier-nb>
Date: Wed, 25 Sep 2024 16:27:32 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 13/23] kbuild: replace two $(abs_objtree) with $(CURDIR)
 in top Makefile

On Tue, Sep 17, 2024 at 11:16:41PM +0900, Masahiro Yamada wrote:
> Kbuild changes the working directory until it matches $(abs_objtree).
> 
> When $(need-sub-make) is empty, $(abs_objtree) is the same as $(CURDIR).
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 5700d08c9b57..ee9ad0f0960f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -228,12 +228,12 @@ else # need-sub-make
>  
>  # We process the rest of the Makefile if this is the final invocation of make
>  
> -ifeq ($(abs_srctree),$(abs_objtree))
> +ifeq ($(abs_srctree),$(CURDIR))
>          # building in the source tree
>          srctree := .
>  	building_out_of_srctree :=
>  else
> -        ifeq ($(abs_srctree)/,$(dir $(abs_objtree)))
> +        ifeq ($(abs_srctree)/,$(dir $(CURDIR)))
>                  # building in a subdirectory of the source tree
>                  srctree := ..
>          else
> -- 
> 2.43.0
> 

Reviewed-by: Nicolas Schier <n.schier@....de>