linux-kernel - Re: [PATCH 12/23] scripts/nsdeps: use VPATH as src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240926-stirring-talented-boa-1b311a@lindesnes>
Date: Thu, 26 Sep 2024 09:30:58 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Nicolas Schier <n.schier@....de>
Cc: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org,
	Miguel Ojeda <ojeda@...nel.org>, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 12/23] scripts/nsdeps: use VPATH as src_prefix

On Wed, Sep 25, 2024 at 04:18:56PM +0200, Nicolas Schier wrote:
> On Tue, Sep 17, 2024 at 11:16:40PM +0900, Masahiro Yamada wrote:
> > This change allows it to work not only for in-tree modules but also for
> > external modules, even if they are built in a separate build directory.
> > 
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> > ---
> > 
> >  scripts/nsdeps | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/nsdeps b/scripts/nsdeps
> > index f1718cc0d700..8b4db63838ce 100644
> > --- a/scripts/nsdeps
> > +++ b/scripts/nsdeps
> > @@ -19,10 +19,10 @@ if ! { echo "$SPATCH_REQ_VERSION"; echo "$SPATCH_VERSION"; } | sort -CV ; then
> >  	exit 1
> >  fi
> >  
> > -if [ "$KBUILD_EXTMOD" ]; then
> > +if [ "${VPATH+set}" ]; then
> >  	src_prefix=
> >  else
> > -	src_prefix=$srctree/
> > +	src_prefix=$VPATH/
> 
> In kbuild, we expect VPATH to be empty or hold one single directory,
> while make itself allows VPATH to be a list of directories.  Might it
> make sense to mention this at some place?

I'd like to withdraw that question.  VPATH usage is an implementation
detail and it's probably not helpful to put too much effort into keeping
such things documentated.