linux-kernel - Re: [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook Go E1404GAB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1276139-d26f-457a-8a73-7f17538dbd28@redhat.com>
Date: Wed, 25 Sep 2024 16:31:54 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Thorsten Leemhuis <linux@...mhuis.info>, Tamim Khan <tamim@...etak.com>,
 linux-acpi@...r.kernel.org
Cc: rafael@...nel.org, lenb@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook Go
 E1404GAB

Hi Thorsten,

On 25-Sep-24 1:56 PM, Thorsten Leemhuis wrote:
> [CCing Hans]

Can you next time maybe also add a bit of text explaining why ?

Often the why is trivial, but in this case I wonder what input you want
from me, see below.

> On 05.09.24 12:45, Thorsten Leemhuis wrote:
>> On 05.09.24 11:51, Thorsten Leemhuis wrote:
>>> On 03.09.24 03:43, Tamim Khan wrote:
>>>> Like other Asus Vivobooks, the Asus Vivobook Go E1404GAB has a DSDT
>>>> that describes IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
>>>> This override prevents the internal keyboard from working. This patch fixes
>>>> this problem by adding this laptop to the table that prevents the kernel from
>>>> overriding the IRQ.
>>>>
>>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219212
>>>
>>> Thx for that. FWIW, I by chance noticed another such report about the
>>> E1404GA: https://bugzilla.kernel.org/show_bug.cgi?id=219224
>>
>> TWIMC, shortly after sending this mail I noticed there is another request
>> for a quirk that was send to the list, bug afaics fall through the
>> cracks. See here:
>> https://lore.kernel.org/all/1226760b-4699-4529-bf57-6423938157a3@wanadoo.fr/
>>
>> It afaics add a X1704VAP:
>>
>> 	{
>> 		/* Asus Vivobook X1704V */
>> 		.matches = {
>> 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> 			DMI_MATCH(DMI_BOARD_NAME, "X1704VAP"),
>> 		},
>> 	},
> 
> FWIW, noticed another such report, this time about the B2502CVA:
> https://bugzilla.kernel.org/show_bug.cgi?id=217760#c12

Ok, I wonder did you Cc me so that I can write / submit patches upstream
for these ones?

It seems that there are 3 missing models:
- E1404GA: https://bugzilla.kernel.org/show_bug.cgi?id=219224
- X1704VAP https://lore.kernel.org/all/1226760b-4699-4529-bf57-6423938157a3@wanadoo.fr/
- B2502CV: https://bugzilla.kernel.org/show_bug.cgi?id=217760#c12

Which someone needs to submit upstream, right ?

> """
>> adding this section to file drivers/acpi/resource.c helped; if someone could do an official patch it would be great :-|
>>
>>         {
>>                 /* Asus ExpertBook B2502CVA */
>>                 .matches = {
>>                         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>>                         DMI_MATCH(DMI_BOARD_NAME, "B2502CVA"),
>>                 },
> """
> 
> This is not a regression, but given how frequently I notice these issues
> please as a bystander allow me to ask: is there maybe some way to
> improve the situation so that we do not have to add all these and likely
> many other Asus Laptops to that file?

This has been discussed before and unfortunately there is no other way
to deal with this. There has been some discussion about reading back
the polarity and edge/level from the hardware for the keyboard IRQ
to get the values which the BIOS has setup. But it is uncertain if this
will work and no one is working on this.

Regards,

Hans