linux-kernel - Re: [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook Go E1404GAB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cf24b3-5ddd-4532-b186-dd1dcc62f712@leemhuis.info>
Date: Wed, 25 Sep 2024 13:56:02 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Tamim Khan <tamim@...etak.com>, linux-acpi@...r.kernel.org
Cc: rafael@...nel.org, lenb@...nel.org, Hans de Goede <hdegoede@...hat.com>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook Go
 E1404GAB

[CCing Hans]

On 05.09.24 12:45, Thorsten Leemhuis wrote:
> On 05.09.24 11:51, Thorsten Leemhuis wrote:
>> On 03.09.24 03:43, Tamim Khan wrote:
>>> Like other Asus Vivobooks, the Asus Vivobook Go E1404GAB has a DSDT
>>> that describes IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
>>> This override prevents the internal keyboard from working. This patch fixes
>>> this problem by adding this laptop to the table that prevents the kernel from
>>> overriding the IRQ.
>>>
>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219212
>>
>> Thx for that. FWIW, I by chance noticed another such report about the
>> E1404GA: https://bugzilla.kernel.org/show_bug.cgi?id=219224
> 
> TWIMC, shortly after sending this mail I noticed there is another request
> for a quirk that was send to the list, bug afaics fall through the
> cracks. See here:
> https://lore.kernel.org/all/1226760b-4699-4529-bf57-6423938157a3@wanadoo.fr/
> 
> It afaics add a X1704VAP:
> 
> 	{
> 		/* Asus Vivobook X1704V */
> 		.matches = {
> 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> 			DMI_MATCH(DMI_BOARD_NAME, "X1704VAP"),
> 		},
> 	},

FWIW, noticed another such report, this time about the B2502CVA:
https://bugzilla.kernel.org/show_bug.cgi?id=217760#c12

"""
> adding this section to file drivers/acpi/resource.c helped; if someone could do an official patch it would be great :-|
> 
>         {
>                 /* Asus ExpertBook B2502CVA */
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>                         DMI_MATCH(DMI_BOARD_NAME, "B2502CVA"),
>                 },
"""

This is not a regression, but given how frequently I notice these issues
please as a bystander allow me to ask: is there maybe some way to
improve the situation so that we do not have to add all these and likely
many other Asus Laptops to that file?

Ciao, Thorsten