[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <216a2a51-7fcb-54df-7287-de504f6dc510@mediatek.com>
Date: Wed, 25 Sep 2024 12:02:01 +0800
From: Macpaul Lin <macpaul.lin@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>, Philipp Zabel
<p.zabel@...gutronix.de>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Yong Wu
<yong.wu@...iatek.com>, Joerg Roedel <joro@...tes.org>, Will Deacon
<will@...nel.org>, Robin Murphy <robin.murphy@....com>, Matthias Brugger
<matthias.bgg@...il.com>, <dri-devel@...ts.freedesktop.org>,
<linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <iommu@...ts.linux.dev>,
<linux-arm-kernel@...ts.infradead.org>, Alexandre Mergnat
<amergnat@...libre.com>, <rohiagar@...omium.org>, <tommyyl.chen@...iatek.com>
CC: Bear Wang <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>,
Macpaul Lin <macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>, Chris-qj
chen <chris-qj.chen@...iatek.com>, MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@...iatek.com>, Chen-Yu Tsai
<wenst@...omium.org>
Subject: Re: [PATCH 6/6] dt-bindings: display: mediatek: dpi: Add mt8195
support in power domains
On 9/24/24 19:48, AngeloGioacchino Del Regno wrote:
> Il 24/09/24 12:31, Macpaul Lin ha scritto:
>> Add power domain binding to the mediatek DPI controller for MT8185.
>>
>> The dpi node in mt8195.dtsi was triggering a dtbs_check error:
>> dp-intf@...13000: power-domains: False schema does not allow [[44, 18]]
>>
>> Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains")
>> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
>> ---
>> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
>> index 3a82aec9021c..07acc8a76bfc 100644
>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
>> @@ -89,6 +89,7 @@ allOf:
>> - mediatek,mt6795-dpi
>> - mediatek,mt8173-dpi
>> - mediatek,mt8186-dpi
>> + - mediatek,mt8195-dp-intf
>
> The dp_intf1 block has a power domain (VDOSYS1)... so that will break the check
> for the other one.
>
> Besides, I'm fairly sure that the right fix is to actually add the missing VDOSYS0
> power domain to dp_intf0 instead, as that block is indeed in VDO0.
>
> So.. for this patch: nak.
>
> Cheers,
> Angelo
Tommy and I was wondering why DP-INTF0 will work without power domain.
After lookup others node in the mt8195.dtsi, I guess this is because the
power domain VDOSYS0 has been enabled by other modules.
However this patch is still required after adding power domain to DP-INTF0.
Otherwise the dpi errors will become two. :~
dp-intf@...15000: power-domains: False schema does not allow [[44, 16]]
dp-intf@...13000: power-domains: False schema does not allow [[44, 18]]
I'll send a separate patch to add VDOSYS0 for DP-INTF0.
Thanks
Macpaul Lin
Powered by blists - more mailing lists