linux-kernel - Re: [PATCH] arm: dts: broadcom: Add missing required fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <170933b4-21ae-4243-b50f-ad75c6fca42c@kernel.org>
Date: Wed, 25 Sep 2024 22:27:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stefan Wahren <wahrenst@....net>,
 Karan Sanghavi <karansanghvi98@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Cc: devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>, Anup <anupnewsmail@...il.com>
Subject: Re: [PATCH] arm: dts: broadcom: Add missing required fields

On 25/09/2024 18:39, Stefan Wahren wrote:
> Hi Karan,
> 
> Am 25.09.24 um 18:14 schrieb Karan Sanghavi:
>> Added below mentioned required fields
>>    1. interrupt-controller
>>    2. #interrupt-cells
>> in the bcm2711.dtsi file for the
>> interrupt-controller@...00000 block as defined in the
>> bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml.
>> This issue was noticed while compiling the dtb file
>> for broadcom/bcm2711-rpi-4-b.dts file.
>> After including the above fields in the dtsi file
>> interrupt-conntroller error was resolved.
> looks like you made the same mistake like me [1]. This change breaks
> boot of Raspberry Pi 4 [2].
> 
> There are a lot of DT schema warnings to fix, but this doesn't belong to
> the trivial ones.
> 

Karan,

Entire commit msg lacks proper rationale for such significant change.
Rationale is for example: "this is an interrupt controller", but here
reason is rather "I want to fix error".

Important for every work focusing on fixing warnings/errors is to fix
the cause, not the warning/error itself. Karan, you fixed the warning in
a way it went away, but this did no fix the cause of the problem. You
must find the real causes. Usually understanding the problem is
necessary for that.

Best regards,
Krzysztof