linux-kernel - Re: [PATCH 4/4] soc: marvell: rvu-pf: Handle function level reset (FLR) IRQs for VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d0bac264a62f4b5f161a53bcaca35b6cef42376.camel@gmail.com>
Date: Wed, 25 Sep 2024 11:19:04 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Anshumali Gaur <agaur@...vell.com>, "conor.dooley@...rochip.com"
 <conor.dooley@...rochip.com>, "ulf.hansson@...aro.org"
 <ulf.hansson@...aro.org>,  "arnd@...db.de" <arnd@...db.de>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>, 
 "nikita.shubin@...uefel.me" <nikita.shubin@...uefel.me>, "vkoul@...nel.org"
 <vkoul@...nel.org>,  "cyy@...self.name" <cyy@...self.name>,
 "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sunil
 Kovvuri Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 4/4] soc: marvell: rvu-pf: Handle function level reset
 (FLR) IRQs for VFs

Hi Anshumali!

On Wed, 2024-09-25 at 09:13 +0000, Anshumali Gaur wrote:
> > > +static irqreturn_t rvu_gen_pf_me_intr_handler(int irq, void *pf_irq)
> > > +{
> > > +	struct gen_pf_dev *pfdev = (struct gen_pf_dev *)pf_irq;
> > > +	int vf, reg, num_reg = 1;
> > > +	u64 intr;
> > > +
> > > +	if (pfdev->total_vfs > 64)
> > > +		num_reg = 2;
> > > +
> > > +	for (reg = 0; reg < num_reg; reg++) {
> > > +		intr = readq(pfdev->reg_base + RVU_PF_VFME_INTX(reg));
> > > +		if (!intr)
> > > +			continue;
> > > +		for (vf = 0; vf < 64; vf++) {
> > > +			if (!(intr & BIT_ULL(vf)))
> > > +				continue;
> > > +			/* clear trpend bit */
> > > +			writeq(BIT_ULL(vf), pfdev->reg_base +
> > RVU_PF_VFTRPENDX(reg));
> > > +			/* clear interrupt */
> > > +			writeq(BIT_ULL(vf), pfdev->reg_base +
> > RVU_PF_VFME_INTX(reg));
> > > +		}
> > > +	}
> > 
> > Should anything else have been performed in the IRQ handler besides
> > acknowledging the IRQ request?
> > 
> We are just acknowledging the IRQ request here. 

But what's the goal of requesting the IRQ in the first place then?

-- 
Alexander Sverdlin.