linux-kernel - Re: [PATCH v2 0/2] firmware: qcom: scm: fix SMC calls on ARM32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1089f44-5415-4a46-a8fb-9711f122a6bd@leemhuis.info>
Date: Wed, 25 Sep 2024 11:35:50 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Andrew Halaney
 <ahalaney@...hat.com>, Elliot Berman <quic_eberman@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Rudraksha Gupta <guptarud@...il.com>,
 Linux kernel regressions list <regressions@...ts.linux.dev>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 0/2] firmware: qcom: scm: fix SMC calls on ARM32

On 11.09.24 11:07, Bartosz Golaszewski wrote:
> The new TZ Mem allocator assumes the SCM driver is always probed which
> apparently isn't the case on older platforms. Add a proper workaround.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> Changes in v2:
> - use likely() for the more likely branch in smc_args_free()
> - Link to v1: https://lore.kernel.org/r/20240909-tzmem-null-ptr-v1-0-96526c421bac@linaro.org

Thx for working on this. This afaics is fixing a regression from the
6.11 cycle; we already missed fixing this for 6.11[1], but please allow
me to ask: is that something that bothers many people and thus should
maybe be fixed rather sooner than later? No pressure, just wondering, as
it seems the review is making slow progress.

Ciao, Thorsten

[1] a 'CC: stable...' thus might be wise, but of course that's up to you
Bartosz!

> ---
> Bartosz Golaszewski (2):
>       firmware: qcom: scm: fix a NULL-pointer dereference
>       firmware: qcom: scm: fall back to kcalloc() for no SCM device bound
> 
>  drivers/firmware/qcom/qcom_scm-smc.c | 28 ++++++++++++++++++++++++----
>  drivers/firmware/qcom/qcom_scm.c     |  2 +-
>  2 files changed, 25 insertions(+), 5 deletions(-)
> ---
> base-commit: 6708132e80a2ced620bde9b9c36e426183544a23
> change-id: 20240909-tzmem-null-ptr-2a9ddd9889aa
> 
> Best regards,