linux-kernel - Re: [PATCH v2] lockdep: add lockdep_cleanup_dead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff9c0a7328c4ead69f9f3b37fe8746ca6a3f03b9.camel@infradead.org>
Date: Thu, 26 Sep 2024 17:37:12 +0100
From: David Woodhouse <dwmw2@...radead.org>
To: Boqun Feng <boqun.feng@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra
 <peterz@...radead.org>,  Ingo Molnar <mingo@...hat.com>, Will Deacon
 <will@...nel.org>, Waiman Long <longman@...hat.com>, Kent Overstreet
 <kent.overstreet@...ux.dev>, Arnd Bergmann <arnd@...db.de>, Sebastian
 Andrzej Siewior <bigeasy@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lockdep: add lockdep_cleanup_dead_cpu()

On Thu, 2024-09-26 at 09:09 -0700, Boqun Feng wrote:
> 
> I won't call this a "perfectly harmless bug", safe_halt() also contains
> tracepoints, which are not supposed to work in offline path IIUC, for
> example, you may incorrectly use RCU when RCU is not watching, that
> could mean reading garbage memory (surely it won't crash the system, but
> I hope I never need to debug such a system ;-)).
> 
> Otherwise this patch looks good to me. Thanks!

Apart from the fact that I can't count. Apparently I got up to v3 of it
last time, so this one should have been v4. I just mostly forgot all
about it, and found it lying around in a git tree a year later, and it
still seemed relevant. 

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)