linux-kernel - Re: [PATCH] dt-bindings: usb: cypress,cypd4226: Drop Tegra specific GPIO defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240926-anybody-purify-f4befab2be4b@spud>
Date: Thu, 26 Sep 2024 17:56:50 +0100
From: Conor Dooley <conor@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Wayne Chang <waynec@...dia.com>,
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: cypress,cypd4226: Drop Tegra specific
 GPIO defines

On Wed, Sep 25, 2024 at 12:34:48PM -0500, Rob Herring (Arm) wrote:
> The Tegra GPIO define is a problem for the magic code which extracts
> the examples and fixes up the interrupt provider. This was partially
> worked around by putting #interrupt-cells in the parent. However,
> that's incomplete and causes a warning when dtc "interrupt_provider"
> check is enabled. Just drop the Tegra specific define and simplify
> the example.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---

Right, there's no need to have a tegra specific thing here at all, its
just an example..
Acked-by: Conor Dooley <conor.dooley@...rochip.com>


>  Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> index 89fc9a434d05..0620d82508c1 100644
> --- a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> @@ -61,18 +61,15 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    #include <dt-bindings/gpio/tegra194-gpio.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      i2c {
>        #address-cells = <1>;
>        #size-cells = <0>;
> -      #interrupt-cells = <2>;
>  
>        typec@8 {
>          compatible = "cypress,cypd4226";
>          reg = <0x08>;
> -        interrupt-parent = <&gpio_aon>;
> -        interrupts = <TEGRA194_AON_GPIO(BB, 2) IRQ_TYPE_LEVEL_LOW>;
> +        interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
>          firmware-name = "nvidia,jetson-agx-xavier";
>          #address-cells = <1>;
>          #size-cells = <0>;
> -- 
> 2.45.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)