linux-kernel - Re: [PATCH v1 09/11] perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvSsB8bT3CTLT4B0@google.com>
Date: Wed, 25 Sep 2024 17:34:15 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
	James Clark <james.clark@...aro.org>,
	Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
	Guo Ren <guoren@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Nick Terrell <terrelln@...com>,
	Guilherme Amadio <amadio@...too.org>,
	Changbin Du <changbin.du@...wei.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Aditya Gupta <adityag@...ux.ibm.com>,
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Huacai Chen <chenhuacai@...nel.org>, Bibo Mao <maobibo@...ngson.cn>,
	Kajol Jain <kjain@...ux.ibm.com>, Anup Patel <anup@...infault.org>,
	Shenlin Liang <liangshenlin@...incomputing.com>,
	Atish Patra <atishp@...osinc.com>,
	Oliver Upton <oliver.upton@...ux.dev>,
	Chen Pei <cp0613@...ux.alibaba.com>,
	Dima Kogan <dima@...retsauce.net>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	Yang Jihong <yangjihong@...edance.com>
Subject: Re: [PATCH v1 09/11] perf build: Rename HAVE_DWARF_SUPPORT to
 HAVE_LIBDW_SUPPORT

On Tue, Sep 24, 2024 at 09:04:16AM -0700, Ian Rogers wrote:
> In Makefile.config for unwinding the name dwarf implies either
> libunwind or libdw. Make it clearer that HAVE_DWARF_SUPPORT is really
> just defined when libdw is present by renaming to HAVE_LIBDW_SUPPORT.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/Documentation/perf-check.txt         |  6 +++---
>  tools/perf/Makefile.config                      |  2 +-
>  tools/perf/arch/powerpc/annotate/instructions.c |  4 ++--
>  tools/perf/arch/x86/annotate/instructions.c     |  2 +-
>  tools/perf/builtin-annotate.c                   |  2 +-
>  tools/perf/builtin-check.c                      |  6 +++---
>  tools/perf/builtin-probe.c                      | 12 ++++++------
>  tools/perf/builtin-report.c                     |  4 ++--
>  tools/perf/util/annotate-data.h                 |  8 ++++----
>  tools/perf/util/debuginfo.h                     |  6 +++---
>  tools/perf/util/disasm.c                        |  4 ++--
>  tools/perf/util/disasm.h                        |  4 ++--
>  tools/perf/util/genelf.c                        |  4 ++--
>  tools/perf/util/genelf.h                        |  2 +-
>  tools/perf/util/include/dwarf-regs.h            |  6 +++---
>  tools/perf/util/probe-event.c                   |  4 ++--
>  tools/perf/util/probe-finder.h                  |  4 ++--
>  17 files changed, 40 insertions(+), 40 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-check.txt b/tools/perf/Documentation/perf-check.txt
> index 45101a8e4154..31741499e786 100644
> --- a/tools/perf/Documentation/perf-check.txt
> +++ b/tools/perf/Documentation/perf-check.txt
> @@ -47,15 +47,15 @@ feature::
>                  bpf                     /  HAVE_LIBBPF_SUPPORT
>                  bpf_skeletons           /  HAVE_BPF_SKEL
>                  debuginfod              /  HAVE_DEBUGINFOD_SUPPORT
> -                dwarf                   /  HAVE_DWARF_SUPPORT
> -                dwarf_getlocations      /  HAVE_DWARF_SUPPORT
> +                dwarf                   /  HAVE_LIBDW_SUPPORT
> +                dwarf_getlocations      /  HAVE_LIBDW_SUPPORT

I'm not sure if we really want to display dwarf_getlocatiosn as it's too
implementation detail IMHO.  Maybe just 'dwarf' or 'libdw' is enough.

Thanks,
Namhyung


>                  dwarf-unwind            /  HAVE_DWARF_UNWIND_SUPPORT
>                  auxtrace                /  HAVE_AUXTRACE_SUPPORT
>                  libaudit                /  HAVE_LIBAUDIT_SUPPORT
>                  libbfd                  /  HAVE_LIBBFD_SUPPORT
>                  libcapstone             /  HAVE_LIBCAPSTONE_SUPPORT
>                  libcrypto               /  HAVE_LIBCRYPTO_SUPPORT
> -                libdw-dwarf-unwind      /  HAVE_DWARF_SUPPORT
> +                libdw-dwarf-unwind      /  HAVE_LIBDW_SUPPORT
>                  libelf                  /  HAVE_LIBELF_SUPPORT
>                  libnuma                 /  HAVE_LIBNUMA_SUPPORT
>                  libopencsd              /  HAVE_CSTRACE_SUPPORT