[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240926074554.GH7545@google.com>
Date: Thu, 26 Sep 2024 08:45:54 +0100
From: Lee Jones <lee@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Chris Packham <chris.packham@...iedtelesis.co.nz>,
andi.shyti@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, sre@...nel.org, tsbogend@...ha.franken.de,
linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
linux-mips@...r.kernel.org
Subject: Re: [PATCH v5 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch
peripherals
Intentional top-post.
These replies all came in without the original mail.
Does anyone have any idea why that would have been?
On Thu, 26 Sep 2024, Krzysztof Kozlowski wrote:
> On Thu, Sep 26, 2024 at 09:58:44AM +1200, Chris Packham wrote:
> > Add device tree schema for the Realtek RTL9300 switches. The RTL9300
> > family is made up of the RTL9301, RTL9302B, RTL9302C and RTL9303. These
> > have the same SoC differ in the Ethernet switch/SERDES arrangement.
> >
> > Currently the only supported features are the syscon-reboot and i2c
> > controllers. The syscon-reboot is needed to be able to reboot the board.
> > The I2C controllers are slightly unusual because they each own an SCL
> > pin (GPIO8 for the first controller, GPIO 17 for the second) but have 8
> > common SDA pins which can be assigned to either controller (but not
> > both).
> >
> > Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> > ---
> >
> > Notes:
> > Changes in v5:
> > I've combined the two series I had in flight so this is the
> > combination of adding the switch syscon, the reboot and i2c. It makes
> > the changelog a bit meaningless so I've dropped the earlier
> > commentary.
> >
> > As requested I've put a more complete example in the main
> > rtl9300-switch.yaml.
> >
> > I've kept rtl9300-i2c.yaml separate for now but link to it with a $ref
> > from rtl9300-switch.yaml to reduce clutter. The example in
> > rtl9300-i2c.yaml is technically duplicating part of the example from
> > rtl9300-switch.yaml but I feel it's nice to be able to see the example
> > next to where the properties are defined.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Best regards,
> Krzysztof
>
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists