linux-kernel - [PATCH] ALSA: serial-generic: explicitly disable flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240926104404.3527124-1-jkeeping@inmusicbrands.com>
Date: Thu, 26 Sep 2024 11:44:03 +0100
From: John Keeping <jkeeping@...usicbrands.com>
To: linux-sound@...r.kernel.org
Cc: John Keeping <jkeeping@...usicbrands.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alex Elder <elder@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Lee Jones <lee@...nel.org>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Daniel Kaehn <kaehndan@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] ALSA: serial-generic: explicitly disable flow control

The serdev subsystem does not specify the default state of flow control
when opening a device.  Surveying other drivers using serdev shows the
vast majority of these set flow control explicitly after opening the
device.

MIDI does not use flow control, so ensure it is disabled.

Fixes: 542350509499f ("ALSA: Add generic serial MIDI driver using serial bus API")
Signed-off-by: John Keeping <jkeeping@...usicbrands.com>
---
 sound/drivers/serial-generic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/drivers/serial-generic.c b/sound/drivers/serial-generic.c
index 36409a56c675e..322b5029ea49f 100644
--- a/sound/drivers/serial-generic.c
+++ b/sound/drivers/serial-generic.c
@@ -139,6 +139,8 @@ static int snd_serial_generic_ensure_serdev_open(struct snd_serial_generic *drvd
 			drvdata->baudrate, drvdata->card->shortname, actual_baud);
 	}
 
+	serdev_device_set_flow_control(drvdata->serdev, false);
+
 	return 0;
 }
 
-- 
2.46.2