linux-kernel - Re: [PATCH] ALSA: serial-generic: explicitly disable flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvZvNIOLX1UMJmC3@hovoldconsulting.com>
Date: Fri, 27 Sep 2024 10:39:16 +0200
From: Johan Hovold <johan@...nel.org>
To: John Keeping <jkeeping@...usicbrands.com>
Cc: linux-sound@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alex Elder <elder@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Lee Jones <lee@...nel.org>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	Rob Herring <robh@...nel.org>, Daniel Kaehn <kaehndan@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: serial-generic: explicitly disable flow control

On Thu, Sep 26, 2024 at 11:44:03AM +0100, John Keeping wrote:
> The serdev subsystem does not specify the default state of flow control
> when opening a device.

This bit isn't correct as serdev enables hardware flow control (CRTSCTS)
by default on open() (see ttyport_open()).

> Surveying other drivers using serdev shows the
> vast majority of these set flow control explicitly after opening the
> device.
> 
> MIDI does not use flow control, so ensure it is disabled.

Johan