linux-kernel - Re: [PATCH 0/2] livepatch: introduce 'stack_order' sysfs interface to klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8A6A3E71-DB43-4305-95FC-202D20B5EC16@gmail.com>
Date: Thu, 26 Sep 2024 19:23:44 +0800
From: zhang warden <zhangwarden@...il.com>
To: Marcos Paulo de Souza <mpdesouza@...e.com>
Cc: Josh Poimboeuf <jpoimboe@...nel.org>,
 Miroslav Benes <mbenes@...e.cz>,
 Jiri Kosina <jikos@...nel.org>,
 Petr Mladek <pmladek@...e.com>,
 Joe Lawrence <joe.lawrence@...hat.com>,
 live-patching@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] livepatch: introduce 'stack_order' sysfs interface to
 klp_patch


> On Sep 25, 2024, at 21:08, Marcos Paulo de Souza <mpdesouza@...e.com> wrote:
> 
> On Wed, 2024-09-25 at 14:40 +0800, Wardenjohn wrote:
>> As previous discussion, maintainers think that patch-level sysfs
>> interface is the
>> only acceptable way to maintain the information of the order that
>> klp_patch is 
>> applied to the system.
>> 
>> However, the previous patch introduce klp_ops into klp_func is a
>> optimization 
>> methods of the patch introducing 'using' feature to klp_func.
>> 
>> But now, we don't support 'using' feature to klp_func and make
>> 'klp_ops' patch
>> not necessary.
>> 
>> Therefore, this new version is only introduce the sysfs feature of
>> klp_patch 
>> 'stack_order'.
> 
> The approach seems ok to me, but I would like to see selftests for this
> new attribute. We have been trying to add more and more selftests for
> existing known behavior, so IMO adding a new attribute should contain a
> new test to exercise the correct behavior.
> 
> Other than that, for the series:
> 
> Acked-by: Marcos Paulo de Souza <mpdesouza@...e.com>
> 

Hi, Macros!

Thanks a lot.

I will add selftest case for it as soon as possible.

Regards.
Wardenjohn.

(This email is resent because it seemed not sent to LKML...)