linux-kernel - Re: [PATCH 0/2] livepatch: introduce 'stack_order' sysfs interface to klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fe8f8d36fb5fc78c645b26c20b5ae365bb59991.camel@suse.com>
Date: Wed, 25 Sep 2024 10:08:22 -0300
From: Marcos Paulo de Souza <mpdesouza@...e.com>
To: Wardenjohn <zhangwarden@...il.com>, jpoimboe@...nel.org, mbenes@...e.cz,
  jikos@...nel.org, pmladek@...e.com, joe.lawrence@...hat.com
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] livepatch: introduce 'stack_order' sysfs interface
 to klp_patch

On Wed, 2024-09-25 at 14:40 +0800, Wardenjohn wrote:
> As previous discussion, maintainers think that patch-level sysfs
> interface is the
> only acceptable way to maintain the information of the order that
> klp_patch is 
> applied to the system.
> 
> However, the previous patch introduce klp_ops into klp_func is a
> optimization 
> methods of the patch introducing 'using' feature to klp_func.
> 
> But now, we don't support 'using' feature to klp_func and make
> 'klp_ops' patch
> not necessary.
> 
> Therefore, this new version is only introduce the sysfs feature of
> klp_patch 
> 'stack_order'.

The approach seems ok to me, but I would like to see selftests for this
new attribute. We have been trying to add more and more selftests for
existing known behavior, so IMO adding a new attribute should contain a
new test to exercise the correct behavior.

Other than that, for the series:

 Acked-by: Marcos Paulo de Souza <mpdesouza@...e.com>

> 
> V1 -> V2:
> 1. According to the suggestion from Petr, to make the meaning more
> clear, rename
> 'order' to 'stack_order'.
> 2. According to the suggestion from Petr and Miroslav, this patch now
> move the 
> calculating process to stack_order_show function. Adding klp_mutex
> lock protection.
> 
> Regards.
> Wardenjohn.
>