linux-kernel - Re: [syzbot] [v9fs?] WARNING in p9_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a72c7a42-0135-4ac7-9cd3-d872dcbe172a@suse.cz>
Date: Thu, 26 Sep 2024 16:55:05 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: asmadeus@...ewreck.org, Pedro Falcato <pedro.falcato@...il.com>
Cc: syzbot <syzbot+3c5d43e97993e1fa612b@...kaller.appspotmail.com>,
 cl@...ux.com, ericvh@...nel.org, linux-kernel@...r.kernel.org,
 linux_oss@...debyte.com, lucho@...kov.net, syzkaller-bugs@...glegroups.com,
 v9fs@...ts.linux.dev
Subject: Re: [syzbot] [v9fs?] WARNING in p9_client_create (2)

On 9/22/24 18:40, asmadeus@...ewreck.org wrote:
> Pedro Falcato wrote on Sun, Sep 22, 2024 at 03:59:17PM +0100:
>> This was one of the issues I actually ran into when using virtme.
>> Fix was submitted here back in August:
>> https://lore.kernel.org/v9fs/20240807094725.2193423-1-pedro.falcato@gmail.com/
>> 
>> No replies nor was it picked up. Can it go through the slab tree?
> 
> Sorry, we're not getting many patches for 9p so I've been slacking and
> trying to batch a bit for when I can find time to pick them up -- don't
> hesitate to ping again if nobody replied in a week or two.
> 
> In this particular case I remember thinking it was a shame we're
> creating a cache for this when most mounts will be sharing the same
> msize but never found time to actually consider how to share the
> caches... But this isn't anything wrong with the patch itself, sorry for
> the delay.
> (and now I'm thinking about it, I guess the slab code has something to
> regroup identical caches? Just looked and didn't find it but I recall
> something like that...)

Yes it does, and it's active by default (although can be disabled), so you
should be fine without doing the grouping on p9 side.

> Anyway, I've just picked that patch up (don't expect any trouble but
> will be queued to next later today), I'll send it to Linus in a week.

Thanks!

> (I'm also adding the syzbot reported by so this gets closed even if it
> came later)
> 
> Thanks!