linux-kernel - Re: [PATCH v2 02/16] media: platform: rzg2l-cru: Mark sink pads with MUST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240927221357.GD12322@pendragon.ideasonboard.com>
Date: Sat, 28 Sep 2024 01:13:57 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	Biju Das <biju.das.jz@...renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 02/16] media: platform: rzg2l-cru: Mark sink pads with
 MUST_CONNECT flag

Hi Prabhakar,

Thank you for the patch.

On Tue, Sep 10, 2024 at 06:53:43PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> Mark the sink pads with the MEDIA_PAD_FL_MUST_CONNECT flag to ensure
> pipeline validation fails if it is not connected.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 +-
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
> index 19e0ba9596c9..69cd45b26951 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
> @@ -209,7 +209,7 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru)
>  	const struct of_device_id *match;
>  	int ret;
>  
> -	cru->pad.flags = MEDIA_PAD_FL_SINK;
> +	cru->pad.flags = MEDIA_PAD_FL_SINK | MEDIA_PAD_FL_MUST_CONNECT;

The corresponding link is ENABLED and IMMUTABLE, so this will not have
any effect. It shouldn't cause any issue though, and makes things more
explicit.

>  	ret = media_entity_pads_init(&cru->vdev.entity, 1, &cru->pad);
>  	if (ret)
>  		return ret;
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c
> index 9f0ea1de50da..db48118fc817 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c
> @@ -217,7 +217,8 @@ int rzg2l_cru_ip_subdev_register(struct rzg2l_cru_dev *cru)
>  	ip->subdev.entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
>  	ip->subdev.entity.ops = &rzg2l_cru_ip_entity_ops;
>  
> -	ip->pads[RZG2L_CRU_IP_SINK].flags = MEDIA_PAD_FL_SINK;
> +	ip->pads[RZG2L_CRU_IP_SINK].flags = MEDIA_PAD_FL_SINK |
> +					    MEDIA_PAD_FL_MUST_CONNECT;

Same here. For this pad, the MUST_CONNECT flag will come handy when
adding support for the parallel input, as the link will not be immutable
anymore.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

>  	ip->pads[RZG2L_CRU_IP_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
>  
>  	ret = media_entity_pads_init(&ip->subdev.entity, 2, ip->pads);

-- 
Regards,

Laurent Pinchart