linux-kernel - Re: [PATCH 1/3] dt-bindings: platform: Add bindings for Lenovo Yoga Slim 7x EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240927225811.GA169571-robh@kernel.org>
Date: Fri, 27 Sep 2024 17:58:11 -0500
From: Rob Herring <robh@...nel.org>
To: Maya Matuszczyk <maccraft123mc@...il.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: platform: Add bindings for Lenovo Yoga
 Slim 7x EC

On Fri, Sep 27, 2024 at 08:53:40PM +0200, Maya Matuszczyk wrote:
> This patch adds devicetree binding documentation for Lenovo Yoga Slim 7x
> EC driver.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@...il.com>
> ---
>  .../platform/lenovo,yoga-slim7x-ec.yaml       | 50 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  2 files changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
> 
> diff --git a/Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml b/Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
> new file mode 100644
> index 000000000000..32f8a0b5d667
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/platform/lenovo,yoga-slim7x-ec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lenovo Yoga Slim 7x Embedded Controller.
> +
> +maintainers:
> +  - Maya Matuszczyk <maccraft123mc@...il.com>
> +
> +description:
> +  The Lenovo Yoga Slim 7x has an EC which handles some minor functions, like
> +  power LED or some special keys on the keyboard. This bindings describes
> +  how it is connected
> +
> +properties:
> +  compatible:
> +    const: lenovo,yoga-slim7x-ec
> +
> +  reg:
> +    const: 0x76
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |+

Drop the '+'

> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c5 {

i2c {

> +        clock-frequency = <400000>;

Not really relevant for the example.

> +
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@76 {
> +            compatible = "lenovo,yoga-slim7x-ec";
> +            reg = <0x76>;
> +
> +            interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_HIGH>;
> +        };
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 00716c1faff6..0d4bfdde166d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12902,6 +12902,11 @@ S:	Maintained
>  W:	http://legousb.sourceforge.net/
>  F:	drivers/usb/misc/legousbtower.c
>  
> +LENOVO YOGA SLIM 7X EC DRIVER
> +M:	Maya Matuszczyk <maccraft123mc@...il.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
> +
>  LETSKETCH HID TABLET DRIVER
>  M:	Hans de Goede <hdegoede@...hat.com>
>  L:	linux-input@...r.kernel.org
> -- 
> 2.45.2
>