linux-kernel - Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9a7cab1-1039-44a8-bf20-33d3b1708b6f@kuruczgy.com>
Date: Sat, 28 Sep 2024 12:35:03 +0200
From: György Kurucz <me@...uczgy.com>
To: Maya Matuszczyk <maccraft123mc@...il.com>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's
 EC

Dear Maya,

> For now it supports only reporting that the AP is going to suspend and
> the microphone mute button, however the EC seems to also support reading
> fan information, other key combinations and thermal data.

I tested the following:
- When I suspend the laptop, the keyboard backlight turns off, and the 
power button LED starts blinking.
- When I press the Fn+F4 key combo, the KEY_MICMUTE event is correctly 
reported to userspace.

> +// These are the registers that i know about available from SMBUS

> +// These are the values in EC_IRQ_REASON_REG that i could find in DSDT

Nitpick: capitalize "I" if you create a v2

Tested-by: György Kurucz <me@...uczgy.com>

Best regards,
György