linux-kernel - Re: [PATCH 03/14] x86/alternative: Simplify callthunk patching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240927232747.q3vcou7c2ueimr32@treble>
Date: Fri, 27 Sep 2024 16:27:47 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, alyssa.milburn@...el.com,
	scott.d.constable@...el.com, joao@...rdrivepizza.com,
	andrew.cooper3@...rix.com, jose.marchesi@...cle.com,
	hjl.tools@...il.com, ndesaulniers@...gle.com,
	samitolvanen@...gle.com, nathan@...nel.org, ojeda@...nel.org,
	kees@...nel.org, alexei.starovoitov@...il.com
Subject: Re: [PATCH 03/14] x86/alternative: Simplify callthunk patching

On Fri, Sep 27, 2024 at 09:48:59PM +0200, Peter Zijlstra wrote:
> -	 * Now all calls are established. Apply the call thunks if
> -	 * required.
> +	 * Adjust call CALL instructions to point to func()-10, including those
> +	 * in .altinstr_replacement.

A couple of tweaks:

"Adjust all CALL instructions to point to func()-0x10..."

-- 
Josh