linux-kernel - Re: [PATCH 2/4] media: dt-bindings: Add OmniVision OV08X40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d727b8e-d8d2-4c3d-a0ee-1db3f17fe5d1@kernel.org>
Date: Sat, 28 Sep 2024 10:24:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Jason Chen <jason.z.chen@...el.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sergey Senozhatsky <senozhatsky@...omium.org>,
 Hans Verkuil <hverkuil-cisco@...all.nl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/4] media: dt-bindings: Add OmniVision OV08X40

On 27/09/2024 01:31, Bryan O'Donoghue wrote:
> On 26/09/2024 16:53, Sakari Ailus wrote:
>>> +      - const: xvclk
>> This seems redundant.
> 
> Right so you're saying you'd prefer something like this
> 
> drivers/media/i2c/ov8865.c
> 
> I can drop the dependency on "xvclk" as a dependency in this series.

Not sure what do you mean here. Drop the clock-names and
clock-frequency. Both are redundant. You should almost never have a
clock-frequency in your device bindings.

Best regards,
Krzysztof