linux-kernel - Re: [PATCH v3] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202409281630.xJUVwU5V-lkp@intel.com>
Date: Sat, 28 Sep 2024 16:24:43 +0800
From: kernel test robot <lkp@...el.com>
To: Werner Sembach <wse@...edocomputers.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, bentiss@...nel.org,
	dri-devel@...ts.freedesktop.org, jelle@...aa.nl, jikos@...nel.org,
	lee@...nel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
	miguel.ojeda.sandonis@...il.com, ojeda@...nel.org,
	onitake@...il.com, pavel@....cz, cs@...edo.de,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3] platform/x86/tuxedo: Add virtual LampArray for TUXEDO
 NB04 devices

Hi Werner,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-tip/drm-tip linus/master v6.11 next-20240927]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Werner-Sembach/platform-x86-tuxedo-Add-virtual-LampArray-for-TUXEDO-NB04-devices/20240927-221932
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240927141745.145176-1-wse%40tuxedocomputers.com
patch subject: [PATCH v3] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices
config: x86_64-buildonly-randconfig-002-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281630.xJUVwU5V-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240928/202409281630.xJUVwU5V-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409281630.xJUVwU5V-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: vmlinux.o: in function `remove':
>> drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_init.c:67: undefined reference to `hid_destroy_device'
   ld: vmlinux.o: in function `__wmi_method_acpi_object_out':
>> drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_util.c:26: undefined reference to `wmidev_evaluate_method'
   ld: vmlinux.o: in function `ll_parse':
>> drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_virtual_lamp_array.c:355: undefined reference to `hid_parse_report'
   ld: vmlinux.o: in function `tuxedo_nb04_virtual_lamp_array_add_device':
>> drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_virtual_lamp_array.c:721: undefined reference to `hid_allocate_device'
>> ld: drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_virtual_lamp_array.c:734: undefined reference to `hid_add_device'
>> ld: drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_virtual_lamp_array.c:736: undefined reference to `hid_destroy_device'
   ld: vmlinux.o: in function `tuxedo_nb04_wmi_ab_driver_init':
>> drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_init.c:86: undefined reference to `__wmi_driver_register'
   ld: vmlinux.o: in function `tuxedo_nb04_wmi_ab_driver_exit':
>> drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_init.c:86: undefined reference to `wmi_driver_unregister'


vim +67 drivers/platform/x86/tuxedo/tuxedo_nb04_wmi_ab_init.c

    62	
    63	static void remove(struct wmi_device *wdev)
    64	{
    65		struct tuxedo_nb04_wmi_driver_data_t *driver_data = dev_get_drvdata(&wdev->dev);
    66	
  > 67		hid_destroy_device(driver_data->virtual_lamp_array_hdev);
    68	}
    69	
    70	static const struct wmi_device_id tuxedo_nb04_wmi_ab_device_ids[] = {
    71		{ .guid_string = "80C9BAA6-AC48-4538-9234-9F81A55E7C85" },
    72		{ }
    73	};
    74	MODULE_DEVICE_TABLE(wmi, tuxedo_nb04_wmi_ab_device_ids);
    75	
    76	static struct wmi_driver tuxedo_nb04_wmi_ab_driver = {
    77		.driver = {
    78			.name = "tuxedo_nb04_wmi_ab",
    79			.probe_type = PROBE_PREFER_ASYNCHRONOUS,
    80		},
    81		.id_table = tuxedo_nb04_wmi_ab_device_ids,
    82		.probe = probe,
    83		.remove = remove,
    84		.no_singleton = true,
    85	};
  > 86	module_wmi_driver(tuxedo_nb04_wmi_ab_driver);
    87	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki