linux-kernel - Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566859c1-a397-4465-987e-0682b07a703e@kernel.org>
Date: Sat, 28 Sep 2024 14:09:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
 linux-kernel@...r.kernel.org
Cc: linux-amarula@...rulasolutions.com, Conor Dooley <conor+dt@...nel.org>,
 Fabio Estevam <festevam@...il.com>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>,
 Peng Fan <peng.fan@....com>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread
 spectrum clocking

On 28/09/2024 10:37, Dario Binacchi wrote:
> The patch adds the DT bindings for enabling and tuning spread spectrum
> clocking generation.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> ---
> 
>  .../bindings/clock/fsl,imx8m-anatop.yaml      | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> index bbd22e95b319..c91eb4229ed3 100644
> --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> @@ -32,6 +32,47 @@ properties:
>  
>    '#clock-cells':
>      const: 1
> +if:

This should be allOf: and placed after required: block, like in example
schema.


> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - fsl,imx8mm-anatop
> +
> +then:
> +  properties:
> +    fsl,ssc-clocks:

Nope. Properties must be defined in top-level.

> +      $ref: /schemas/types.yaml#/definitions/phandle-array
> +      description:
> +        The phandles to the PLLs with spread spectrum clock generation
> +        hardware capability.

These should be clocks.

> +      maxItems: 4
> +
> +    fsl,ssc-modfreq-hz:
> +      $ref: /schemas/types.yaml#/definitions/uint32-array

This should fail. I don't think you tested this patch.

https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

> +      description:
> +        The values of modulation frequency (Hz unit) of spread spectrum
> +        clocking for each PLL.
> +      maxItems: 4
> +
> +    fsl,ssc-modrate-percent:

Same problems



Best regards,
Krzysztof