linux-kernel - Re: [PATCH v2 1/6] dt-bindings: ti, sci: Add property for partial-io-wakeup-sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7ec2c3a-fab3-4ca1-9c18-f0fd00554e09@kernel.org>
Date: Sat, 28 Sep 2024 14:13:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Markus Schneider-Pargmann <msp@...libre.com>
Cc: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
 Santosh Shilimkar <ssantosh@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Vignesh Raghavendra <vigneshr@...com>,
 Vibhore Vardhan <vibhore@...com>, Kevin Hilman <khilman@...libre.com>,
 Dhruva Gole <d-gole@...com>, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: ti, sci: Add property for
 partial-io-wakeup-sources

On 27/09/2024 11:35, Markus Schneider-Pargmann wrote:
>>>
>>> It's not obvious for me. Maybe you can elaborate a bit.
>>>
>>> The hardware has a different set of wakeup sources depending on the
>>> power mode it is in and I would like to describe these different sets of
>>> wakeup sources in the devicetree as for me this is a hardware property,
>>> not a driver thing.
>>
>> I stated the argument to which you did not respond: it will not matter
>> for the device whether this is wakeup-source = S2R or wakeup-source =
>> TI-Partial-IO or whatever.
>>
>> Each device is or is not wakeup source.
>>
>> And just because your device has some registers or some configuration
>> does not mean this property is suitable for DT.
> 
> I came up with a different (better) way to model this in the devicetree.
> This group of units that are powered in Partial-IO are all powered by
> just one regulator that is always on. I can simply describe this in the
> devicetree by defining the regulator and consumer relationship:
> 
> Defining the regulator as described in the board schematic:
> 
>   vddshv_canuart: regulator-7 {
>          /* TPS22965DSGT */
>          compatible = "regulator-fixed";
>          regulator-name = "vddshv_canuart";
>          regulator-min-microvolt = <3300000>;
>          regulator-max-microvolt = <3300000>;
>          vin-supply = <&vcc_3v3_main>;
>          regulator-always-on;
>          regulator-boot-on;
>   };
> 
> Adding vio-supply to mcan and uarts, note, this binding does not exist
> yet:
> 
>   &mcu_mcan0 {
>          vio-supply = <&vddshv_canuart>;
>   };
> 
>   &mcu_mcan1 {
>          vio-supply = <&vddshv_canuart>;
>   };
> 
>   &mcu_uart0 {
>          vio-supply = <&vddshv_canuart>;
>   };
> 
>   &wkup_uart0 {
>          vio-supply = <&vddshv_canuart>;
>   };
> 

I am happy that problem is solved, but it really, really puzzles me how
above fits wakeup-mode-problem at all. This is so different that I doubt
you came up with proper hardware description.

Best regards,
Krzysztof