linux-kernel - Re: [PATCH] dt-bindings: iio: dac: adi,ad56xx: Fix duplicate compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240928145049.74dabfee@jic23-huawei>
Date: Sat, 28 Sep 2024 14:50:49 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Michael Auchter
 <michael.auchter@...com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: adi,ad56xx: Fix duplicate
 compatible strings

On Mon, 16 Sep 2024 10:22:19 -0500
Rob Herring <robh@...nel.org> wrote:

> On Sat, Sep 14, 2024 at 9:18 AM Jonathan Cameron <jic23@...nel.org> wrote:
> >
> > On Tue, 10 Sep 2024 18:44:39 -0500
> > "Rob Herring (Arm)" <robh@...nel.org> wrote:
> >  
> > > adi,ad5686.yaml and adi,ad5696.yaml duplicate all the I2C device
> > > compatible strings with the exception of "adi,ad5337r". Since
> > > adi,ad5686.yaml references spi-peripheral-props.yaml, drop the I2C
> > > devices from it making it only SPI devices. Update the titles to make
> > > the distinction clear.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>  
> > Is this an urgent thing, or can it wait for the merge window after next?
> > For now I've queued it up for then in my testing branch but can yank it
> > out and send it as a fix after rc1 if that is useful.  
> 
> Sooner would be better. It's now a warning in dtschema main branch.
> The issue is not so much the duplication, but that which schema gets
> applied is not deterministic.

Shifted it to my fixes-togreg branch. I'll do a pull request for that
fairly soon (once rc1 is out and it's had a little soak in next)

Thanks,

Jonathan

> 
> Rob