linux-kernel - Re: [PATCH v2] clk: qcom: clk-alpha-pll: Fix pll post div mask when width is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9369ebfeae8bc1aad3f9da4a6453c3d@mainlining.org>
Date: Sat, 28 Sep 2024 19:05:39 +0200
From: barnabas.czeman@...nlining.org
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Satya Priya
 Kakitapalli <quic_skakitap@...cinc.com>, Konrad Dybcio
 <konradybcio@...nel.org>, Abhishek Sahu <absahu@...eaurora.org>,
 linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH v2] clk: qcom: clk-alpha-pll: Fix pll post div mask when
 width is not set

On 2024-09-25 23:28, Dmitry Baryshkov wrote:
> On Wed, Sep 25, 2024 at 08:33:20PM GMT, Barnabás Czémán wrote:
>> Many qcom clock drivers do not have .width set. In that case value of
>> (p)->width - 1 will be negative which breaks clock tree. Fix this
>> by checking if width is zero, and pass 3 to GENMASK if that's the 
>> case.
>> 
>> Fixes: 1c3541145cbf ("clk: qcom: support for 2 bit PLL post divider")
>> Fixes: 2c4553e6c485 ("clk: qcom: clk-alpha-pll: Fix the pll post div 
>> mask")
> 
> I think one Fixes tag should be enough.
Should I send a v3 remove one of them or not needed?
> 
> Nevertheless,
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> ---
>> Changes in v2:
>> - Pass 3 to GENMASK instead of 0.
>> - Add more Fixes tag for reference root cause.
>> - Link to v1: 
>> https://lore.kernel.org/r/20240925-fix-postdiv-mask-v1-1-f70ba55f415e@mainlining.org
>> ---
>>  drivers/clk/qcom/clk-alpha-pll.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)