linux-kernel - Re: [PATCH] function_graph: Simplify the initialization of fgraph LRU data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240927201755.6402ed04@rorschach.local.home>
Date: Fri, 27 Sep 2024 20:17:55 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Liao Chang <liaochang1@...wei.com>
Cc: <mhiramat@...nel.org>, <mark.rutland@....com>,
 <mathieu.desnoyers@...icios.com>, <linux-kernel@...r.kernel.org>,
 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH] function_graph: Simplify the initialization of fgraph
 LRU data

On Thu, 12 Sep 2024 11:15:50 +0000
Liao Chang <liaochang1@...wei.com> wrote:

> This patch uses [first ... last] = value to initialize fgraph_array[].
> And it declares all the callbacks in fgraph_stub as static, as they are
> not called from external code.

This patch doesn't look like a simplification, and it is incorrect
about the "not called from external code" as the kernel test robot
pointed out!

-- Steve