linux-kernel - Re: [PATCH] function_graph: Simplify the initialization of fgraph LRU data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c566bff1-b209-9660-2837-9d3b8fca3fb6@huawei.com>
Date: Mon, 30 Sep 2024 15:16:59 +0800
From: "Liao, Chang" <liaochang1@...wei.com>
To: Steven Rostedt <rostedt@...dmis.org>
CC: <mhiramat@...nel.org>, <mark.rutland@....com>,
	<mathieu.desnoyers@...icios.com>, <linux-kernel@...r.kernel.org>,
	<linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH] function_graph: Simplify the initialization of fgraph LRU
 data



在 2024/9/28 8:17, Steven Rostedt 写道:
> On Thu, 12 Sep 2024 11:15:50 +0000
> Liao Chang <liaochang1@...wei.com> wrote:
> 
>> This patch uses [first ... last] = value to initialize fgraph_array[].
>> And it declares all the callbacks in fgraph_stub as static, as they are
>> not called from external code.
> 
> This patch doesn't look like a simplification, and it is incorrect
> about the "not called from external code" as the kernel test robot
> pointed out!

Yes, I overlooked the external call, the static keyword is removed
in the next revision. The patch just makes code neat, it isn't a real
simplification.

> 
> -- Steve
> 

-- 
BR
Liao, Chang