linux-kernel - Re: [PATCH 1/2] device: rust: change the name function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <32476CD7-74D6-4575-9D93-2FBCD5AE3E10@collabora.com>
Date: Sun, 29 Sep 2024 12:35:09 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Guilherme Giácomo Simões <trintaeoitogc@...il.com>
Cc: rafael@...nel.org,
 ojeda@...nel.org,
 alex.gaynor@...il.com,
 boqun.feng@...il.com,
 gary@...yguo.net,
 bjorn3_gh@...tonmail.com,
 benno.lossin@...ton.me,
 aliceryhl@...gle.com,
 mcgrof@...nel.org,
 russ.weight@...ux.dev,
 dakr@...hat.com,
 a.hindborg@...nel.org,
 "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] device: rust: change the name function

Hi Guilherme, welcome to the community!

The commit message needs some work IMHO. In particular, links may become stale,
so please do not link to anything.

It’s also written in first person and in a verbose way, which is not good.
Just describe what you did and why the change was necessary succinctly.

You can find some more tips at
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Lastly, I can’t see a diff anywhere. Make sure everything you send can
actually be applied and *at least* compile-check your changes. Submitting
patches that do not apply and/or do not compile can make people lose interest.

Send a v2 with the fixes above and we can start to actually discuss your code.

BR

— Daniel