linux-kernel - Re: [PATCH] selftests: timers: improve timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCrzWz0=5az1a9_-rzCYo42ex0aNbXgdso9sx55BAEp_jg@mail.gmail.com>
Date: Mon, 30 Sep 2024 12:19:52 -0700
From: John Stultz <jstultz@...gle.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Gianfranco Trad <gianf.trad@...il.com>, tglx@...utronix.de, sboyd@...nel.org, 
	anna-maria@...utronix.de, frederic@...nel.org, shuah@...nel.org, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: timers: improve timer_create failure message

On Mon, Sep 30, 2024 at 11:49 AM Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 8/29/24 09:37, Gianfranco Trad wrote:
> > improve timer_create failure message with strerror() function
> > to give more information to the user.
> >
> > Signed-off-by: Gianfranco Trad <gianf.trad@...il.com>
> > ---
> >   tools/testing/selftests/timers/alarmtimer-suspend.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c
> > index ad52e608b88e..74acdb87d4f4 100644
> > --- a/tools/testing/selftests/timers/alarmtimer-suspend.c
> > +++ b/tools/testing/selftests/timers/alarmtimer-suspend.c
> > @@ -28,6 +28,7 @@
> >   #include <signal.h>
> >   #include <stdlib.h>
> >   #include <pthread.h>
> > +#include <errno.h>
> >   #include "../kselftest.h"
> >
> >   #define CLOCK_REALTIME                      0
> > @@ -142,8 +143,8 @@ int main(void)
> >
> >               alarmcount = 0;
> >               if (timer_create(alarm_clock_id, &se, &tm1) == -1) {
> > -                     printf("timer_create failed, %s unsupported?\n",
> > -                                     clockstring(alarm_clock_id));
> > +                     printf("timer_create failed, %s unsupported?: %s\n",
> > +                                     clockstring(alarm_clock_id), strerror(errno));
> >                       break;
> >               }
> >
>
> Jon, Does this look good to you? I can pick this up if you
> okay with this change.

No objection from me, sorry this slipped by me.

Acked-by: John Stultz <jstultz@...gle.com>