linux-kernel - Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7910784d-18c2-4e72-9dd8-6b8bd1b9dd0b@linuxfoundation.org>
Date: Mon, 30 Sep 2024 14:57:26 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Benjamin Tissoires <bentiss@...nel.org>, Yun Lu <luyun@...inos.cn>
Cc: jikos@...nel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

On 9/30/24 02:38, Benjamin Tissoires wrote:
> On Sep 29 2024, Yun Lu wrote:
>> The HID test cases actually run tests using the run-hid-tools-tests.sh
>> script. However, if installed with "make install", the run-hid-tools-tests.sh
>> script will not be copied over, resulting in the following error message.
>>
>>    make -C tools/testing/selftests/ TARGETS=hid install \
>>    	  INSTALL_PATH=$KSFT_INSTALL_PATH
>>
>>    cd $KSFT_INSTALL_PATH
>>    ./run_kselftest.sh -c hid
>>
>> selftests: hid: hid-core.sh
>> bash: ./run-hid-tools-tests.sh: No such file or directory
>>
>> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
>>
> 
> I assume we probably also want:
> 
> Cc: stable@...r.kernel.org
> 
>> Signed-off-by: Yun Lu <luyun@...inos.cn>
> 
> Not sure about the timing regarding our next PR to Linus, so in any cases:
> 
> Acked-by: Benjamin Tissoires <bentiss@...nel.org>

Thank you. This commit appears to be right one for Fixes tag?

Is this the right commit for Fixes tag:

Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")

Will apply with this tag added to linux-kselftest fixes for next rc
once I get conformation.

thanks,
-- Shuah