linux-kernel - Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mimf5cv52q747fwhafr7pv6lgxyyt3rauz373e7hoinpqycmha@2oncke2rw2sc>
Date: Mon, 30 Sep 2024 10:38:32 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: Yun Lu <luyun@...inos.cn>
Cc: jikos@...nel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

On Sep 29 2024, Yun Lu wrote:
> The HID test cases actually run tests using the run-hid-tools-tests.sh
> script. However, if installed with "make install", the run-hid-tools-tests.sh
> script will not be copied over, resulting in the following error message.
> 
>   make -C tools/testing/selftests/ TARGETS=hid install \
>   	  INSTALL_PATH=$KSFT_INSTALL_PATH
> 
>   cd $KSFT_INSTALL_PATH
>   ./run_kselftest.sh -c hid
> 
> selftests: hid: hid-core.sh
> bash: ./run-hid-tools-tests.sh: No such file or directory
> 
> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
> 

I assume we probably also want:

Cc: stable@...r.kernel.org

> Signed-off-by: Yun Lu <luyun@...inos.cn>

Not sure about the timing regarding our next PR to Linus, so in any cases:

Acked-by: Benjamin Tissoires <bentiss@...nel.org>

Cheers,
Benjamin

> ---
>  tools/testing/selftests/hid/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
> index 72be55ac4bdf..38ae31bb07b5 100644
> --- a/tools/testing/selftests/hid/Makefile
> +++ b/tools/testing/selftests/hid/Makefile
> @@ -17,6 +17,8 @@ TEST_PROGS += hid-tablet.sh
>  TEST_PROGS += hid-usb_crash.sh
>  TEST_PROGS += hid-wacom.sh
>  
> +TEST_FILES := run-hid-tools-tests.sh
> +
>  CXX ?= $(CROSS_COMPILE)g++
>  
>  HOSTPKG_CONFIG := pkg-config
> -- 
> 2.27.0
>