[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240930100331.1e7573e0@jic23-huawei>
Date: Mon, 30 Sep 2024 10:03:31 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Lars-Peter Clausen
<lars@...afoo.de>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add
iam20680ht/hp bindings to mpu6050
On Mon, 30 Sep 2024 08:46:05 +0000
Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com> wrote:
> Hello Jonathan
>
> for the explanation, the chip variants at reset have a FIFO restricted to 512 bytes like the original one. You have to write specific bits in a register to unlock the FIFO to its full size.
>
> The driver is writing these bits only when you configure the variant. Otherwise, it will behave really like the original one.
>
> That's why I call them fully compatible.
Even then I'd go with 'backwards compatible'.
A driver that assumed the new device and tried to use that wouldn't work
with the IAM-20680 so it is one way compatibility.
The binding is fine, just the patch description may imply more than intended.
Jonathan
>
> Thanks,
> JB
>
> ________________________________________
> From: Jonathan Cameron <jic23@...nel.org>
> Sent: Saturday, September 28, 2024 18:45
> To: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>; Lars-Peter Clausen <lars@...afoo.de>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; devicetree@...r.kernel.org <devicetree@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
>
> This Message Is From an External Sender
> This message came from outside your organization.
>
> On Mon, 23 Sep 2024 17:38:44 +0200
> Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> > On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
> > >
> > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > > They just have better specs, temperature range and a bigger FIFO.
> > >
> > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
> > > ---
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Ah. I missed v2 as checked by email address.
>
> As per v1 review I've tweaked this patch description to say they are
> backwards compatible rather than fully (as the fifo size is not
> discoverable)
>
> Jonathan
>
> >
> > Best regards,
> > Krzysztof
> >
>
Powered by blists - more mailing lists