linux-kernel - Re: [PATCH 2/2] device: rust: change the name function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_Rzfaa49C29kGf7YoUvhaADTQzN_QYvdNJDTfakU10=7U+Dw@mail.gmail.com>
Date: Mon, 30 Sep 2024 08:50:05 -0300
From: Guilherme Giácomo Simões <trintaeoitogc@...il.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc: rafael@...nel.org, ojeda@...nel.org, alex.gaynor@...il.com, 
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	benno.lossin@...ton.me, aliceryhl@...gle.com, mcgrof@...nel.org, 
	russ.weight@...ux.dev, dakr@...hat.com, a.hindborg@...nel.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] device: rust: change the name function

gregkh@...uxfoundation.org <gregkh@...uxfoundation.org> writes:
>
> On Sun, Sep 29, 2024 at 10:38:47AM -0300, Guilherme Giácomo Simões wrote:
> > This function increments the refcount by this command
> > "bindings::get_device(prt)"
> > This can be confused because the function Arc::from_raw() from
> > standard library, doesn't
> > increment the refcount.
> > Then, this function "Device::from_raw()" will be renamed for don't
> > make confusion
> > in the future.
>
> Please wrap the lines here properly so they show up in a sane way :)
>
> >
> > Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
> > ---
> >  rust/kernel/device.rs   | 2 +-
> >  rust/kernel/firmware.rs | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs
> > index 851018eef885..ecffaff041e0 100644
> > --- a/rust/kernel/device.rs
> > +++ b/rust/kernel/device.rs
> > @@ -51,7 +51,7 @@ impl Device {
> >      ///
> >      /// It must also be ensured that `bindings::device::release` can
> > be called from any thread.
>
> Your patch is line-wrapped and can not be applied :(
>
> Please read the email documentation in the kernel for how to use gmail
> to send patches out (hint, almost never do so, but you can use git
> send-email through it), that will help you in sending changes that can
> be applied.

So, I really send the patch with gmail. But, I make this because my
git send-email have any bug and I don't fix this.
I'll see what's happening with my send-email and send the next patch through it.


>
> >      /// While not officially documented, this should be the case for
> > any `struct device`.
> > -    pub unsafe fn from_raw(ptr: *mut bindings::device) -> ARef<Self> {
> > +    pub unsafe fn get_device(ptr: *mut bindings::device) -> ARef<Self> {
>
> With this change, nothing broke?  Does nothing call this code yet?  I
> thought the firmware interface did that, but I could be wrong...
>
> thanks,
>
> greg k-h

This change don't broke nothing. The Device::from_raw() don't is used
yet. The firmware only have a Documentation for calling the
Device::from_raw()
and I change this Doc too.