linux-kernel - Re: [PATCH v2 03/16] media: platform: rzg2l-cru: rzg2l-csi2: Mark sink and source pad with MUST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8v=Su=FPUVXoqRqPJkhoWALT5U-7BQmTaogbTAQ4Y-xJw@mail.gmail.com>
Date: Mon, 30 Sep 2024 12:51:01 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 03/16] media: platform: rzg2l-cru: rzg2l-csi2: Mark
 sink and source pad with MUST_CONNECT flag

Hi Laurent,

Thank you for the review.

On Fri, Sep 27, 2024 at 11:24 PM Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Tue, Sep 10, 2024 at 06:53:44PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Mark the sink and source pad with the MEDIA_PAD_FL_MUST_CONNECT flag to
> > ensure pipeline validation fails if it is not connected.
>
> The MUST_CONNECT flag only affects sink pads. That's not documented
> though, and it seems that most drivers using the flag sets it on both
> sink and source pads. That's probably a good practice, and the fact that
> the flag is only checked for sink pads is more of an implementation
> detail. This patch is thus fine.
>
Agreed.

> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>
> However, I think you should then set the flag on the source pad of the
> IP entity in patch 02/16. You can keep my Rb.
>
Sure, I'll add this flag in v3.

Cheers,
Prabhakar