linux-kernel - Re: [PATCH v2] i2c: amd-asf: Fix uninitialized variables issue in amd_asf_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a69cd7b2-b74b-4ea2-9235-8f0958777c27@amd.com>
Date: Mon, 30 Sep 2024 10:03:23 +0530
From: Shyam Sundar S K <Shyam-sundar.S-k@....com>
To: Qianqiang Liu <qianqiang.liu@....com>,
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: amd-asf: Fix uninitialized variables issue in
 amd_asf_process_target

Hi,

On 9/27/2024 19:04, Qianqiang Liu wrote:
> The len variable is not initialized, which may cause the for loop to
> behave unexpectedly.
> 
> Fixes: 20c3cc299218 ("i2c: amd-asf: Add routine to handle the ASF slave process")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>

Thank you for the fix.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>

Thanks,
Shyam

> ---
>  drivers/i2c/busses/i2c-amd-asf-plat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c
> index 47e0c90341aed..ba47df5370c72 100644
> --- a/drivers/i2c/busses/i2c-amd-asf-plat.c
> +++ b/drivers/i2c/busses/i2c-amd-asf-plat.c
> @@ -61,7 +61,7 @@ static void amd_asf_process_target(struct work_struct *work)
>  	unsigned short piix4_smba = dev->port_addr->start;
>  	u8 data[ASF_BLOCK_MAX_BYTES];
>  	u8 bank, reg, cmd;
> -	u8 len, idx, val;
> +	u8 len = 0, idx, val;
>  
>  	/* Read target status register */
>  	reg = inb_p(ASFSLVSTA);