linux-kernel - Re: [PATCH v6 5/7] gpio: aspeed: Change the macro to support deferred probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <506c41f97dc0243ed156f1775006ef30fe4a3f54.camel@codeconstruct.com.au>
Date: Mon, 30 Sep 2024 14:07:39 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Billy Tsai <billy_tsai@...eedtech.com>, linus.walleij@...aro.org, 
 brgl@...ev.pl, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
 joel@....id.au, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
 linux-kernel@...r.kernel.org, BMC-SW@...eedtech.com,
 Peter.Yin@...ntatw.com,  Jay_Zhang@...ynn.com
Subject: Re: [PATCH v6 5/7] gpio: aspeed: Change the macro to support
 deferred probe

On Fri, 2024-09-27 at 19:17 +0800, Billy Tsai wrote:
> Use module_platform_driver() to replace module_platform_driver_probe().
> The former utilizes platform_driver_register(), which allows the driver to
> defer probing when it doesn't acquire the necessary resources due to probe
> order. In contrast, the latter uses __platform_driver_probe(), which
> includes the comment "Note that this is incompatible with deferred
> probing." Since our GPIO driver requires access to the clock resource, the
> former is more suitable.
> 
> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>

Seems okay to make it less of a deviant, though maybe we should fix the
sgpio drive as well? Anyway:

Reviewed-by: Andrew Jeffery <andrew@...econstruct.com.au>

Andrew