linux-kernel - Re: [PATCH 1/3] gpio: dwapb: switch to device_for_each_child_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdb+C5u4cQ0EapgXTzuwL-9CE2MrimRd11U3O8c6vajjNQ@mail.gmail.com>
Date: Tue, 1 Oct 2024 16:13:46 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Hoan Tran <hoan@...amperecomputing.com>, Serge Semin <fancer.lancer@...il.com>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/3] gpio: dwapb: switch to device_for_each_child_node_scoped()

On Sat, Sep 28, 2024 at 9:47 PM Javier Carrasco
<javier.carrasco.cruz@...il.com> wrote:

> Switch to device_for_each_child_node_scoped() to simplify the code by
> removing the need for a  call to fwnode_handle_put() in the error path.
>
> This also prevents possible memory leaks if new error paths are added
> without the required call to fwnode_handle_put().
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Neat.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij