linux-kernel - Re: (subset) [PATCH 0/3] gpio: switch to device_for_each_chilld_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172780884672.98871.5009069255744218803.b4-ty@linaro.org>
Date: Tue,  1 Oct 2024 20:54:20 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Hoan Tran <hoan@...amperecomputing.com>,
	Serge Semin <fancer.lancer@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: (subset) [PATCH 0/3] gpio: switch to device_for_each_chilld_node_scoped()

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Sat, 28 Sep 2024 21:47:34 +0200, Javier Carrasco wrote:
> This series switches from the device_for_each_child_node() macro to its
> scoped variant. This makes the code more robust if new early exits are
> added to the loops, because there is no need for explicit calls to
> fwnode_handle_put(), which also simplifies existing code.
> 
> The non-scoped macros to walk over nodes turn error-prone as soon as
> the loop contains early exits (break, goto, return), and patches to
> fix them show up regularly, sometimes due to new error paths in an
> existing loop [1].
> 
> [...]

Applied, thanks!

[1/3] gpio: dwapb: switch to device_for_each_child_node_scoped()
      commit: 0a53be8e080b53ef922e90204999f4ccef29cd57
[2/3] gpio: sim: switch to device_for_each_child_node_scoped()
      commit: d64d0287f4bc7013c60b07e34e43c3fc558e3808

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>