linux-kernel - Re: [PATCH v2] Bluetooth: btrtl: Decrease HCI_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABBYNZJj+gtmSUUz4gUigkg3GUaBuR29jEU=ZxKjxu7cPSv1Yw@mail.gmail.com>
Date: Tue, 1 Oct 2024 11:29:17 -0400
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Hilda Wu <hildawu@...ltek.com>
Cc: marcel@...tmann.org, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, alex_lu@...lsil.com.cn, max.chou@...ltek.com, 
	kidman@...ltek.com, howardchung@...gle.com, apusaka@...omium.org, 
	yinghsu@...omium.org, johnlai@...gle.com
Subject: Re: [PATCH v2] Bluetooth: btrtl: Decrease HCI_OP_RESET timeout from
 10 s to 2 s

Hi Hilda,

On Tue, Oct 1, 2024 at 3:43 AM Hilda Wu <hildawu@...ltek.com> wrote:
>
> The original timeout setting for HCI Reset on shutdown is 10 seconds.
> Since the HCI Reset processing time is soon, so decrease the timeout
> to 2 seconds for HCI Reset on shutdown.

I guess you are saying that HCI Reset shouldn't take 10 seconds to
complete so instead use the default timeout for commands. I can update
the description myself if you agree to use the above sentence.

> Signed-off-by: Hilda Wu <hildawu@...ltek.com>
> ---
> V1 -> V2: Modify commit message and summary
> ---
> ---
>  drivers/bluetooth/btrtl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 2d95b3ea046d..7128a8a0ba25 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -1371,7 +1371,7 @@ int btrtl_shutdown_realtek(struct hci_dev *hdev)
>         /* According to the vendor driver, BT must be reset on close to avoid
>          * firmware crash.
>          */
> -       skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_INIT_TIMEOUT);
> +       skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_CMD_TIMEOUT);
>         if (IS_ERR(skb)) {
>                 ret = PTR_ERR(skb);
>                 bt_dev_err(hdev, "HCI reset during shutdown failed");
> --
> 2.34.1
>


-- 
Luiz Augusto von Dentz