linux-kernel - Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241001-sleet-bronchial-867258945373@spud>
Date: Tue, 1 Oct 2024 16:31:21 +0100
From: Conor Dooley <conor@...nel.org>
To: Andrei Simion <andrei.simion@...rochip.com>
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev,
	alexandre.belloni@...tlin.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Alexander Dhal <ada@...rsis.com>
Subject: Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED
 sub nodes

On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote:
> Add the label property here and use the old node name as value to stay
> stable and avoid breaking the userspace applications that depend on those
> paths.
> 
> Suggested-by: Alexander Dhal <ada@...rsis.com>
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>

Shouldn't this be squashed with 3/4 so as not to break it in one commit,
only to fix it in another?

> ---
> v1 -> v2:
> - added in v2 by suggestion of Alexander Dhal
> ---
>  arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
> index 0c3373ad1723..b65f80e1ef05 100644
> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
> @@ -99,22 +99,26 @@ leds {
>  		compatible = "gpio-leds";
>  
>  		led-red {
> +			label = "red";
>  			gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "none";
>  		};
>  
>  		led-green {
> +			label = "green";
>  			gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "none";
>  			default-state = "on";
>  		};
>  
>  		led-yellow {
> +			label = "yellow";
>  			gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "none";
>  		};
>  
>  		led-blue {
> +			label = "blue";
>  			gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "none";
>  		};
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)