| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241001161042.465584-6-chang.seok.bae@intel.com>
Date: Tue, 1 Oct 2024 09:10:40 -0700
From: "Chang S. Bae" <chang.seok.bae@...el.com>
To: linux-kernel@...r.kernel.org
Cc: x86@...nel.org,
tglx@...utronix.de,
mingo@...hat.com,
bp@...en8.de,
dave.hansen@...ux.intel.com,
chang.seok.bae@...el.com
Subject: [PATCH RFC 5/7] x86/microcode/intel_staging: Implement staging logic
The staging firmware operates through a protocol via the MMIO interface.
The protocol defines a serialized sequence that begins by clearing the
hardware with an abort request. It then proceeds through iterative
process of sending data, initiating transactions, waiting for processing,
and reading responses.
To facilitate this interaction, follow the outlined protocol. Refactor
the waiting code to manage loop breaks more effectively. Data transfer
involves a next level of detail to handle the mailbox format. While
defining helpers, leave them empty for now.
Signed-off-by: Chang S. Bae <chang.seok.bae@...el.com>
---
arch/x86/kernel/cpu/microcode/Makefile | 2 +-
arch/x86/kernel/cpu/microcode/intel_staging.c | 105 ++++++++++++++++++
arch/x86/kernel/cpu/microcode/internal.h | 6 +-
3 files changed, 107 insertions(+), 6 deletions(-)
create mode 100644 arch/x86/kernel/cpu/microcode/intel_staging.c
diff --git a/arch/x86/kernel/cpu/microcode/Makefile b/arch/x86/kernel/cpu/microcode/Makefile
index 193d98b33a0a..a9f79aaffcb0 100644
--- a/arch/x86/kernel/cpu/microcode/Makefile
+++ b/arch/x86/kernel/cpu/microcode/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
microcode-y := core.o
obj-$(CONFIG_MICROCODE) += microcode.o
-microcode-$(CONFIG_CPU_SUP_INTEL) += intel.o
+microcode-$(CONFIG_CPU_SUP_INTEL) += intel.o intel_staging.o
microcode-$(CONFIG_CPU_SUP_AMD) += amd.o
diff --git a/arch/x86/kernel/cpu/microcode/intel_staging.c b/arch/x86/kernel/cpu/microcode/intel_staging.c
new file mode 100644
index 000000000000..9989a78f9ef2
--- /dev/null
+++ b/arch/x86/kernel/cpu/microcode/intel_staging.c
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#define pr_fmt(fmt) "microcode: " fmt
+#include <linux/delay.h>
+#include <linux/io.h>
+
+#include "internal.h"
+
+#define MBOX_REG_NUM 4
+#define MBOX_REG_SIZE sizeof(u32)
+
+#define MBOX_CONTROL_OFFSET 0x0
+#define MBOX_STATUS_OFFSET 0x4
+
+#define MASK_MBOX_CTRL_ABORT BIT(0)
+
+#define MASK_MBOX_STATUS_ERROR BIT(2)
+#define MASK_MBOX_STATUS_READY BIT(31)
+
+#define MBOX_XACTION_LEN PAGE_SIZE
+#define MBOX_XACTION_MAX(imgsz) ((imgsz) * 2)
+#define MBOX_XACTION_TIMEOUT (10 * MSEC_PER_SEC)
+
+#define STAGING_OFFSET_END 0xffffffff
+
+static inline void abort_xaction(void __iomem *base)
+{
+ writel(MASK_MBOX_CTRL_ABORT, base + MBOX_CONTROL_OFFSET);
+}
+
+static void request_xaction(void __iomem *base, u32 *chunk, unsigned int chunksize)
+{
+ pr_debug_once("Need to implement staging mailbox loading code.\n");
+}
+
+static enum ucode_state wait_for_xaction(void __iomem *base)
+{
+ u32 timeout, status;
+
+ for (timeout = 0; timeout < MBOX_XACTION_TIMEOUT; timeout++) {
+ msleep(1);
+ status = readl(base + MBOX_STATUS_OFFSET);
+ if (status & MASK_MBOX_STATUS_READY)
+ break;
+ }
+
+ status = readl(base + MBOX_STATUS_OFFSET);
+ if (status & MASK_MBOX_STATUS_ERROR)
+ return UCODE_ERROR;
+ if (!(status & MASK_MBOX_STATUS_READY))
+ return UCODE_TIMEOUT;
+
+ return UCODE_OK;
+}
+
+static enum ucode_state read_xaction_response(void __iomem *base, unsigned int *offset)
+{
+ pr_debug_once("Need to implement staging response handler.\n");
+ return UCODE_ERROR;
+}
+
+static inline unsigned int get_chunksize(unsigned int totalsize, unsigned int offset)
+{
+ WARN_ON_ONCE(totalsize < offset);
+ return min(MBOX_XACTION_LEN, totalsize - offset);
+}
+
+bool staging_work(u64 mmio_pa, void *ucode_ptr, unsigned int totalsize)
+{
+ unsigned int xaction_bytes = 0, offset = 0, chunksize;
+ void __iomem *mmio_base;
+ enum ucode_state state;
+
+ mmio_base = ioremap(mmio_pa, MBOX_REG_NUM * MBOX_REG_SIZE);
+ if (WARN_ON_ONCE(!mmio_base))
+ return false;
+
+ abort_xaction(mmio_base);
+
+ while (offset != STAGING_OFFSET_END) {
+ chunksize = get_chunksize(totalsize, offset);
+ if (xaction_bytes + chunksize > MBOX_XACTION_MAX(totalsize)) {
+ state = UCODE_TIMEOUT;
+ break;
+ }
+
+ request_xaction(mmio_base, ucode_ptr + offset, chunksize);
+ state = wait_for_xaction(mmio_base);
+ if (state != UCODE_OK)
+ break;
+
+ xaction_bytes += chunksize;
+ state = read_xaction_response(mmio_base, &offset);
+ if (state != UCODE_OK)
+ break;
+ }
+
+ iounmap(mmio_base);
+
+ if (state == UCODE_OK)
+ return true;
+
+ pr_err("Staging failed with %s.\n", state == UCODE_TIMEOUT ? "timeout" : "error");
+ return false;
+}
diff --git a/arch/x86/kernel/cpu/microcode/internal.h b/arch/x86/kernel/cpu/microcode/internal.h
index 06c3c8db4ceb..6b0d9a4374db 100644
--- a/arch/x86/kernel/cpu/microcode/internal.h
+++ b/arch/x86/kernel/cpu/microcode/internal.h
@@ -120,11 +120,7 @@ void load_ucode_intel_bsp(struct early_load_data *ed);
void load_ucode_intel_ap(void);
void reload_ucode_intel(void);
struct microcode_ops *init_intel_microcode(void);
-static inline bool staging_work(u64 mmio_pa, void *ucode_ptr, unsigned int totalsize)
-{
- pr_debug_once("Need to implement the Staging code.\n");
- return false;
-}
+bool staging_work(u64 mmio_pa, void *ucode_ptr, unsigned int totalsize);
#else /* CONFIG_CPU_SUP_INTEL */
static inline void load_ucode_intel_bsp(struct early_load_data *ed) { }
static inline void load_ucode_intel_ap(void) { }
--
2.43.0
Powered by blists - more mailing lists